Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: Add missing tests for parsePostForm #17368

Closed
asticode opened this issue Oct 6, 2016 · 2 comments
Closed

net/http: Add missing tests for parsePostForm #17368

asticode opened this issue Oct 6, 2016 · 2 comments
Labels
FrozenDueToAge Suggested Testing help wanted
Milestone
Unplanned

Comments

@asticode
Copy link
Contributor

@asticode asticode commented Oct 6, 2016

@bradfitz since #14655 has been reverted I think that would be wise to patch tests as well in TestPostQuery and TestPatchQuery with use cases mentionned in https://go-review.googlesource.com/#/c/30454/ and https://go-review.googlesource.com/#/c/30470/ so that those cases are not forgotten in the future. What do you think ?
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor

@bradfitz bradfitz commented Oct 6, 2016

Sounds good.
@bradfitz bradfitz added this to the Unreleased milestone Oct 6, 2016
@bradfitz bradfitz added the Testing label Oct 6, 2016
@bradfitz bradfitz modified the milestones: Unplanned, Unreleased Oct 6, 2016
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Oct 6, 2016

CL https://golang.org/cl/30555 mentions this issue.
@gopherbot gopherbot closed this in 5f1a013 Oct 9, 2016
@golang golang locked and limited conversation to collaborators Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Testing help wanted
Projects
None yet
Milestone
  Unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@asticode @bradfitz @gopherbot
You can’t perform that action at this time.