Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/present: textarea displaying .code is always editable #17379

Closed
0xmohit opened this issue Oct 7, 2016 · 2 comments
Closed

x/tools/present: textarea displaying .code is always editable #17379

0xmohit opened this issue Oct 7, 2016 · 2 comments
Assignees

Comments

@0xmohit
Copy link
Contributor

@0xmohit 0xmohit commented Oct 7, 2016

What version of Go are you using (go version)?

go version go1.7.1 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH=""
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build108877481=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?

git clone https://github.com/bradfitz/talk-2016-08-16-seattle-go-1.7
cd talk-2016-08-16-seattle-go-1.7
present

Navigate to slide 33. Observe the textarea displaying the code. It corresponds to the following:

.code src/context_http.go /START OMIT/,/END OMIT/

What did you expect to see?

The textarea displaying the code shouldn't be editable (-edit not specified).

What did you see instead?

All such code blocks are editable.

@robpike
Copy link
Contributor

@robpike robpike commented Oct 7, 2016

Ha! This happened to me in talk at Gophercon this year.

@campoy
Copy link
Contributor

@campoy campoy commented Oct 7, 2016

Working on adding tests to the way this works, then I'll fix the bug

jjneely pushed a commit to jjneely/present that referenced this issue Nov 4, 2016
Also added a suite of tests and fixed a minor bug that
caused a panic when the .code command specified HL with
no text after.

Fixes golang/go#17379.

Change-Id: I3c246523c3d4010bf76a467ee648475255090e1b
Reviewed-on: https://go-review.googlesource.com/30691
Reviewed-by: Rob Pike <r@golang.org>
@golang golang locked and limited conversation to collaborators Oct 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.