Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/arch/ppc64/ppc64asm: Fixes for ppc64 disassembly #17447

Closed
laboger opened this issue Oct 14, 2016 · 2 comments
Closed

x/arch/ppc64/ppc64asm: Fixes for ppc64 disassembly #17447

laboger opened this issue Oct 14, 2016 · 2 comments
Labels
FrozenDueToAge NeedsFix
Milestone

Comments

@laboger
Copy link
Contributor

@laboger laboger commented Oct 14, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

tip + golang.org/x/arch/ppc64

What operating system and processor architecture are you using (go env)?

Ubuntu 16.04 ppc64le & RHEL 7.2 ppc64 BE

What did you do?

Testing the disassembly support for ppc64 that was recently added to golang.org/x/arch/ppc64/ppc64asm, and found some errors in the testcase and in objdump output.

I have some changes for missing and incorrect opcode mappings as well as corrections to some testcases.

@quentinmit quentinmit added the NeedsFix label Oct 17, 2016
@quentinmit quentinmit added this to the Go1.8 milestone Oct 17, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 17, 2016

CL https://golang.org/cl/31146 mentions this issue.

@mikioh mikioh changed the title arch: Fixes for ppc64 disassembly x/arch/ppc64/ppc64asm: Fixes for ppc64 disassembly Oct 18, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2016

CL https://golang.org/cl/32015 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 25, 2016
Update the ppc64x disassembly code for use by objdump
from golang.org/x/arch/ppc64/ppc64asm commit fcea5ea.
Enable the objdump testcase for external linking on ppc64le
make a minor fix to the expected output.

Fixes #17447

Change-Id: I769cc7f8bfade594690a476dfe77ab33677ac03b
Reviewed-on: https://go-review.googlesource.com/32015
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Oct 25, 2017
@rsc rsc unassigned laboger Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix
Projects
None yet
Development

No branches or pull requests

3 participants