Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestLldbPython fails on macOS Sierra #17463

Closed
YoshikiShibata opened this issue Oct 16, 2016 · 9 comments

Comments

Projects
None yet
6 participants
@YoshikiShibata
Copy link

commented Oct 16, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version devel +ad5fd28 Sat Oct 15 21:27:45 2016 +0000 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/yoshiki/gocode:/Users/yoshiki/exercises/gpl"
GORACE=""
GOROOT="/Users/yoshiki/tools/go"
GOTOOLDIR="/Users/yoshiki/tools/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/r3/f30_9n8958j4ndrjyl1k7mp40000gn/T/go-build223200854=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?

I tried to rebuild go with src/all.bash.

What did you expect to see?

The build is OK

What did you see instead?

ok path/filepath 0.112s
ok reflect 0.115s
ok regexp 0.129s
ok regexp/syntax 0.353s
--- FAIL: TestLldbPython (4.38s)
runtime-lldb_test.go:182: Unexpected lldb output:
Created target
Created breakpoint
Process launched
Hit breakpoint
no intvar
FAIL
FAIL runtime 40.270s
ok runtime/debug 0.018s

@mikioh mikioh changed the title TestLldbPython fails runtime: TestLldbPython fails Oct 16, 2016

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2016

Looks like this issue happens only on macOS 10.12 Sierra.

@mikioh mikioh added the help wanted label Oct 17, 2016

@mikioh mikioh changed the title runtime: TestLldbPython fails runtime: TestLldbPython fails on macOS Sierra Oct 17, 2016

@quentinmit quentinmit added this to the Go1.8 milestone Oct 17, 2016

@quentinmit

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2016

I'm able to repro this. TestLldbPython is skipped by default; you need to enable developer mode with DevToolsSecurity -enable before it will run.

@bradfitz, presumably this is why we're not failing on the buildbots. Can you add that command to the setup process for new OS X VMs?

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 18, 2016

Is there a way to programmatically do it without a password prompt?

@quentinmit

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2016

In classic Apple fashion, it's not documented. Does it still prompt if run as root?

If so, try

/usr/sbin/dseditgroup -o edit -t user -a $user _developer

as root. Google thinks that might work.

@quentinmit

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2016

I just tested it and DevToolsSecurity -enable runs without a password prompt when run by root.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 19, 2016

@quentinmit, cool. Want to file a separate builder-specific bug? There are two separate things to fix with two separate owners I think: enabling this on our builders, vs actually fixing this.

Oh, and we also need Sierra builders too.

@josharian

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2016

git bisect says 7c431cb / CL 29397 broke this.

cc @cherrymui @crawshaw

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2016

CL https://golang.org/cl/31725 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 22, 2016

runtime: skip TestLldbPython
The test is broken on macOS Sierra.

Updates #17463.

Change-Id: Ifbb2379c640b9353a01bc55a5cb26dfaad9b4bdc
Reviewed-on: https://go-review.googlesource.com/31725
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Oct 27, 2016

CL https://golang.org/cl/32185 mentions this issue.

@gopherbot gopherbot closed this in 9d1efba Oct 28, 2016

@golang golang locked and limited conversation to collaborators Oct 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.