x/build: run standard library tests without -short #17472
I saw some bugs with go test in cmd/go, so I decided to run everything without -short. Need to run go test without -short once in a while on the whole tree. I tried it today and there were some disappointments.
I'll let someone else decide if they want to break out individual bugs for the failures, but the point made in the first paragraph still stands: Before release, test everything.
What version of Go are you using (
referenced this issue
Oct 30, 2016
This was referenced
Oct 31, 2016
I just ran
I'm going to repurpose this issue as being to run a builder without -short, and move it off the Go 1.8 release milestone.
changed the title
all: various failures when all tests are run without -short
Nov 15, 2016
I see an odd failure in the original test output:
--- FAIL: TestRepoRootForImportPath (1.02s)
In other words, the test is passing a URL ending in "swift.git" to repoRootForImportPath but the path returned ends in "swift". The test is expecting the returned URL to end with "swift.git".
I'm seeing the same failure in my area, and I was curious if anyone could give me tips
Was that failure one of the failures that was split out and fixed in this issue?
Whoops. Nevermind. I saw my problem in 1.7ish and It goes away in 1.8.3. Must be due to some vcs.go changes.