Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: run standard library tests without -short #17472
I saw some bugs with go test in cmd/go, so I decided to run everything without -short. Need to run go test without -short once in a while on the whole tree. I tried it today and there were some disappointments.
I'll let someone else decide if they want to break out individual bugs for the failures, but the point made in the first paragraph still stands: Before release, test everything.
What version of Go are you using (
TestAssembly takes 20s on my machine, which is too slow for normal operation. Marking as -short has its dangers (#17472), but hopefully we'll soon have a builder for that. All the SSA tests are hermetic and not time sensitive and can thus be run in parallel. Reduces the cmd/compile/internal/gc test time during all.bash on my laptop from 42s to 7s. Updates #17751 Change-Id: Idd876421db23b9fa3475e8a9b3355a5dc92a5a29 Reviewed-on: https://go-review.googlesource.com/32585 Run-TryBot: Josh Bleecher Snyder <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>
I just ran
I'm going to repurpose this issue as being to run a builder without -short, and move it off the Go 1.8 release milestone.
I see an odd failure in the original test output:
--- FAIL: TestRepoRootForImportPath (1.02s)
In other words, the test is passing a URL ending in "swift.git" to repoRootForImportPath but the path returned ends in "swift". The test is expecting the returned URL to end with "swift.git".
I'm seeing the same failure in my area, and I was curious if anyone could give me tips
Was that failure one of the failures that was split out and fixed in this issue?
Whoops. Nevermind. I saw my problem in 1.7ish and It goes away in 1.8.3. Must be due to some vcs.go changes.
This is necessary when you aren't actively changing the runtime. Oops. Also, run the tests on the builders, to avoid silent failures (#17472). Change-Id: I1fc03790cdbddddb07026a772137a79919dcaac7 Reviewed-on: https://go-review.googlesource.com/58050 Run-TryBot: Josh Bleecher Snyder <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Ian Lance Taylor <email@example.com>