Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestReadTimeoutUnblocksRead is failing on Plan 9 #17477

Closed
0intro opened this issue Oct 17, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@0intro
Copy link
Member

commented Oct 17, 2016

CL 31178 added TestReadTimeoutUnblocksRead. However, this test is failing on Plan 9, because deadlines aren't implemented on Plan 9 yet (#11932).

Stacks at timeout:
 goroutine 135 [running]:
net.TestReadTimeoutUnblocksRead.func1(0x10640b18, 0x0, 0x0)
    /tmp/workdir/go/src/net/net_test.go:486 +0x199
net.withTCPConnPair.func2(0x24c860, 0x10640ac0, 0x10644f80, 0x10640a88)
    /tmp/workdir/go/src/net/net_test.go:446 +0xbf
created by net.withTCPConnPair
    /tmp/workdir/go/src/net/net_test.go:447 +0xfd

goroutine 1 [chan receive]:
testing.(*T).Run(0x1048e400, 0x1a448a, 0x1b, 0x1abaf8, 0x93901)
    /tmp/workdir/go/src/testing/testing.go:658 +0x244
testing.RunTests.func1(0x1048e400)
    /tmp/workdir/go/src/testing/testing.go:804 +0x4c
testing.tRunner(0x1048e400, 0x104b7f00)
    /tmp/workdir/go/src/testing/testing.go:621 +0x73
testing.RunTests(0x1ab798, 0x262320, 0x99, 0x99, 0xb)
    /tmp/workdir/go/src/testing/testing.go:810 +0x229
testing.(*M).Run(0x104b7f7c, 0x1)
    /tmp/workdir/go/src/testing/testing.go:754 +0x6a
net.TestMain(0x104b7f7c)
    /tmp/workdir/go/src/net/main_test.go:48 +0x25
main.main()
    net/_test/_testmain.go:400 +0xbb

goroutine 133 [chan receive]:
net.withTCPConnPair(0x10650880, 0x10640a90, 0x10640a88)
    /tmp/workdir/go/src/net/net_test.go:449 +0x136
net.TestReadTimeoutUnblocksRead(0x10650880)
    /tmp/workdir/go/src/net/net_test.go:498 +0xbe
testing.tRunner(0x10650880, 0x1abaf8)
    /tmp/workdir/go/src/testing/testing.go:621 +0x73
created by testing.(*T).Run
    /tmp/workdir/go/src/testing/testing.go:657 +0x223

goroutine 134 [chan receive]:
net.TestReadTimeoutUnblocksRead.func2(0x10640b00, 0x24d7b4, 0x10640b00)
    /tmp/workdir/go/src/net/net_test.go:495 +0x31
net.withTCPConnPair.func1(0x24c860, 0x10640ac0, 0x10644f80, 0x10640a90)
    /tmp/workdir/go/src/net/net_test.go:437 +0x89
created by net.withTCPConnPair
    /tmp/workdir/go/src/net/net_test.go:438 +0xc7

goroutine 137 [syscall]:
syscall.Syscall6(0x8, 0x10498fa7, 0x1, 0xffffffff, 0xffffffff, 0x0, 0x0, 0x10649738, 0x10498f6c, 0x1064eae0, ...)
    /tmp/workdir/go/src/syscall/asm_plan9_386.s:57 +0x5
syscall.Pread(0x8, 0x10498fa7, 0x1, 0x1, 0xffffffff, 0xffffffff, 0xca024, 0x10645040, 0x0)
    /tmp/workdir/go/src/syscall/zsyscall_plan9_386.go:228 +0x62
syscall.Read(0x8, 0x10498fa7, 0x1, 0x1, 0x10492000, 0x800000, 0x0)
    /tmp/workdir/go/src/syscall/syscall_plan9.go:124 +0x48
os.(*File).read(0x10640b08, 0x10498fa7, 0x1, 0x1, 0x4, 0x10490f20, 0x10498f60)
    /tmp/workdir/go/src/os/file_plan9.go:242 +0x3c
os.(*File).Read(0x10640b08, 0x10498fa7, 0x1, 0x1, 0x10492000, 0x10645040, 0x0)
    /tmp/workdir/go/src/os/file.go:101 +0x44
net.(*netFD).Read(0x10645040, 0x10498fa7, 0x1, 0x1, 0x0, 0x0, 0x0)
    /tmp/workdir/go/src/net/fd_plan9.go:82 +0xea
net.(*conn).Read(0x10640b18, 0x10498fa7, 0x1, 0x1, 0x0, 0x0, 0x0)
    /tmp/workdir/go/src/net/net.go:176 +0x55
net.TestReadTimeoutUnblocksRead.func1.1(0x10645080, 0x10640b18)
    /tmp/workdir/go/src/net/net_test.go:476 +0x87
created by net.TestReadTimeoutUnblocksRead.func1
    /tmp/workdir/go/src/net/net_test.go:480 +0xa5

goroutine 25 [syscall]:
syscall.Syscall6(0x3, 0x10499e10, 0x19, 0xffffffff, 0xffffffff, 0x0, 0x0, 0x10, 0xffffffff, 0xffffffff, ...)
    /tmp/workdir/go/src/syscall/asm_plan9_386.s:57 +0x5
syscall.Pwrite(0x3, 0x10499e10, 0x19, 0x20, 0xffffffff, 0xffffffff, 0x2, 0x2, 0x369a0)
    /tmp/workdir/go/src/syscall/zsyscall_plan9_386.go:245 +0x62
syscall.Write(0x3, 0x10499e10, 0x19, 0x20, 0x2, 0x2, 0x2)
    /tmp/workdir/go/src/syscall/syscall_plan9.go:128 +0x48
os.(*File).write(0x1049e650, 0x10499e10, 0x19, 0x20, 0x10499e10, 0x10499e78, 0x19)
    /tmp/workdir/go/src/os/file_plan9.go:260 +0x40
os.(*File).Write(0x1049e650, 0x10499e10, 0x19, 0x20, 0x19, 0x20, 0x0)
    /tmp/workdir/go/src/os/file.go:142 +0x44
os.(*File).WriteString(0x1049e650, 0x10499e78, 0x19, 0x1049180f, 0x11, 0x10499e78)
    /tmp/workdir/go/src/os/file.go:203 +0x60
net.dialPlan9Blocking(0x24ca20, 0x104917c0, 0x19e24f, 0x3, 0x24c540, 0x0, 0x24c540, 0x104917e0, 0x0, 0x0, ...)
    /tmp/workdir/go/src/net/ipsock_plan9.go:200 +0xe7
net.dialPlan9.func2(0x24ca20, 0x104917c0, 0x19e24f, 0x3, 0x24c540, 0x0, 0x24c540, 0x104917e0, 0x104bb480)
    /tmp/workdir/go/src/net/ipsock_plan9.go:178 +0x85
created by net.dialPlan9
    /tmp/workdir/go/src/net/ipsock_plan9.go:186 +0x10c

--- FAIL: TestReadTimeoutUnblocksRead (5.03s)
    net_test.go:450: timeout waiting for Read to finish

See https://build.golang.org/log/61959edbf9a940676d03349ba91d02f17bf9541f

@0intro 0intro added the OS-Plan9 label Oct 17, 2016

@0intro 0intro self-assigned this Oct 17, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Oct 17, 2016

CL https://golang.org/cl/31188 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 17, 2016

net: skip TestReadTimeoutUnblocksRead on Plan 9
Deadlines aren't implemented on Plan 9 yet.

Updates #17477.

Change-Id: I44ffdbef97276dfec56547e5189672b7da24bfc1
Reviewed-on: https://go-review.googlesource.com/31188
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: David du Colombier <0intro@gmail.com>

@quentinmit quentinmit added this to the Unplanned milestone Oct 17, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Nov 12, 2016

CL https://golang.org/cl/33190 mentions this issue.

@gopherbot gopherbot closed this in 4966150 Nov 12, 2016

@golang golang locked and limited conversation to collaborators Nov 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.