Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: tests failing on Plan 9 since CL 31173 #17498

0intro opened this issue Oct 18, 2016 · 4 comments

net/http: tests failing on Plan 9 since CL 31173 #17498

0intro opened this issue Oct 18, 2016 · 4 comments


Copy link

@0intro 0intro commented Oct 18, 2016

Since CL 31173 the HTTP server relies on deadlines to read requests from clients. This change broke various tests in the net/http package, because deadlines aren't implemented on Plan 9 yet.

2016/10/18 03:15:56 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0x10976f98 in state active
  *net.TCPConn 0x10976110 in state active
panic: test timed out after 3m0s
FAIL    net/http    180.069s


@0intro 0intro added the OS-Plan9 label Oct 18, 2016
@0intro 0intro added this to the Go1.8 milestone Oct 18, 2016
@0intro 0intro self-assigned this Oct 18, 2016
@bradfitz bradfitz modified the milestones: Go1.8Maybe, Go1.8 Oct 18, 2016
Copy link

@rsc rsc commented Oct 20, 2016

To be clear, the fix here is to implement deadlines on Plan 9, right?

Copy link

@bradfitz bradfitz commented Oct 20, 2016

Yes. And there's now a pending CL for it too.

Copy link
Member Author

@0intro 0intro commented Oct 20, 2016

Yes, we have to implement deadlines on Plan 9.
I've proposed an experimental implementation in CL 31521, which is able to pass the currents tests (and more).

Copy link

@gopherbot gopherbot commented Oct 26, 2016

CL mentions this issue.

@gopherbot gopherbot closed this in adb384a Nov 12, 2016
@golang golang locked and limited conversation to collaborators Nov 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants