Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: mksyscall_windows.go doesn't generate syscalldot for internal/syscall/windows. #17539

Closed
mattn opened this issue Oct 21, 2016 · 6 comments
Closed
Assignees
Milestone

Comments

@mattn
Copy link
Member

@mattn mattn commented Oct 21, 2016

What version of Go are you using (go version)?

go version devel +9670403 Mon Oct 17 09:20:04 2016 +0900 windows/amd64

What operating system and processor architecture are you using (go env)?

Windows7 64bit

What did you do?

go generate on $GOROOT/src/internal/syscall/windows, then go build.

What did you expect to see?

No errors

What did you see instead?

Compilation error

# internal/syscall/windows
.\zsyscall_windows.go:16: undefined: ERROR_IO_PENDING
.\zsyscall_windows.go:25: undefined: ERROR_IO_PENDING
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 21, 2016

CL https://golang.org/cl/31541 mentions this issue.

@mattn
Copy link
Member Author

@mattn mattn commented Oct 21, 2016

I sent CL 31541

But I wonder how this part was generated.

ca264cd

I guess errWSAEINPROGRESS is meaning-less. cc: @bradfitz @alexbrainman

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Oct 21, 2016

Does https://go-review.googlesource.com/#/c/29690/ fixes your problem?

Alex

@mattn
Copy link
Member Author

@mattn mattn commented Oct 21, 2016

Yes, abandoned my CL. Thank you. please fix this. We must merge by hand always after do go generate in internal/syscall/windows.

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Oct 21, 2016

Will fix.

Alex

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 21, 2016

CL https://golang.org/cl/29690 mentions this issue.

@quentinmit quentinmit added this to the Go1.8 milestone Oct 21, 2016
@gopherbot gopherbot closed this in b7477f3 Oct 22, 2016
@golang golang locked and limited conversation to collaborators Oct 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.