Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: TestLoadFixed failure #17545

Closed
lfam opened this issue Oct 21, 2016 · 7 comments

Comments

Projects
None yet
7 participants
@lfam
Copy link

commented Oct 21, 2016

What version of Go are you using (go version)?

go version go1.4.3 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCHAR="6"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH=""
GORACE=""
GOROOT="/gnu/store/avygi1jh3ki2cji6fb9i0lg1h3r2nz80-go-1.4.3"
GOTOOLDIR="/gnu/store/avygi1jh3ki2cji6fb9i0lg1h3r2nz80-go-1.4.3/pkg/tool/linux_amd64"
CC="/gnu/store/frrj3bfbmg5vrd0flh9cf8j64h7cr2v4-gcc-4.9.3/bin/gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="0"

What did you do?

Trying to rebuild Go 1.4.3 with tzdata 2016g, the test TestLoadFixed fails:

--- FAIL: TestLoadFixed (0.00s)
    time_test.go:929: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600
FAIL
FAIL    time    2.473s

This is the same underlying issue as in #17276. That is, the name of the time zone used in the test has changed in tzdata 2016g. However, the fix suggested in that ticket does not work for 1.4.3. When I apply the patch that fixes the bug for the 1.7 release series, compilation fails like this:

 # Building C bootstrap tool.
cmd/dist

# Building compilers and Go bootstrap tool for host, linux/amd64.
lib9
go tool dist: missing file /tmp/guix-build-go-1.4.3.drv-0/go/include/fmt.h

What did you expect to see?

A successful test suite.

What did you see instead?

A failure of TestLoadFixed.

What do you suggest for distributions that use Go 1.4.3 to bootstrap later versions of Go?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2016

First, I suggest that you not care about a failure in the time package when building Go 1.4 solely in order to build a later version of Go. A test failure of that sort doesn't matter. Don't worry about it.

Second, I'm afraid that I simply don't believe that your 1.4 sources built before you applied the change in https://golang.org/cl/29995 but then failed to build in the way that you describe after you applied that change. That change could not cause that failure. Either that failure existed before you applied that change, or you changed more than just that one file.

@lfam

This comment has been minimized.

Copy link
Author

commented Oct 21, 2016

First, I suggest that you not care about a failure in the time package when building Go 1.4 solely in order to build a later version of Go. A test failure of that sort doesn't matter. Don't worry about it.

Thanks for the advice. We'll skip that test.

Second, I'm afraid that I simply don't believe that your 1.4 sources built before you applied the change in https://golang.org/cl/29995 but then failed to build in the way that you describe after you applied that change. That change could not cause that failure. Either that failure existed before you applied that change, or you changed more than just that one file.

Intriguing.

Our packaging [0] alters the Go sources in these ways:

  1. Delete some tests that require networking, which is not available in the Guix build environment.
  2. Disable some other tests that all seem to be related to Unix shell operations. I didn't make that part of the packaging, so I don't know off-hand how they fail.
  3. Patch paths to a variety of dependencies.

I'm afraid that I'm simply not a Go programmer, so I can't say if these changes would cause the failure in question when combined with the fix for #17276.

However, our 1.4.3 package does successfully bootstrap 1.7.1 and 1.7.3, which I do use to build working Go applications.

[0] If you see anything amiss, I'd be very glad if you told us.
http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/golang.scm?h=core-updates&id=f08add0c5a3f1f7200b0a00e17ed880692d2244b#n47

@quentinmit quentinmit added this to the Go1.4.4 milestone Oct 24, 2016

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 24, 2016

Decision from meeting: we'll just skip this test on the Go 1.4 branch.

/cc @josharian

@gopherbot

This comment has been minimized.

Copy link

commented Oct 24, 2016

CL https://golang.org/cl/31855 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 24, 2016

[release-branch.go1.4] time: skip TestLoadFixed on the Go 1.4 branch
Fixes #17545

Change-Id: I146e5e172174d8855289d173625ad0d115bc6ccc
Reviewed-on: https://go-review.googlesource.com/31855
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@minux

This comment has been minimized.

Copy link
Member

commented Oct 25, 2016

@josharian

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2016

@minux when cherry-picking fixes to 1.4, it's nice to have confirmation that all.bash runs. Skipping tests on release-branch.go1.4 whose failures are known to be unimportant seems a reasonable approach to take. I'll still close this issue, though, since CL 31855 went in. (I think GitHub only auto-closes based on commit messages when commits land in the master branch.)

@josharian josharian closed this Oct 25, 2016

hartzell added a commit to hartzell/spack that referenced this issue Nov 19, 2016

Update go-bootstrap package
The last C based Go src tree was the 1.4 series.  For a while they
were cutting new releases so that people could bootstrap from a C only
system.  Now they're recommending that you either use the release-1.4
branch or that you use a date-stamped tarball that they'll produce on
an as-needed basis.

There are several issues that keep 1.4.2 from building on a CentOS 7
system.

I've switched to the date based tarball.

The cgo bits were also mis-behaving, but they're not needed for the
bootstrapping task so I've set an environment variable that disables
them.

Details [on the install-from-source
page](https://golang.org/doc/install/source#go14) and these issues:

- golang/go#17545
- golang/go#16352.

hartzell added a commit to hartzell/spack that referenced this issue Nov 19, 2016

Update go package
Switched from pulling from the git repository to using the source
tarballs and added digest values.

Added support for 1.7.3, continued supporting 1.6.2, including patches
for a couple of problems (details in
[17545](golang/go#17545) and
[17986](golang/go#17986).

Dropped support for 1.5.4 and 1.4.2 because they no longer pass their
tests and the patches above to not apply.

tgamblin added a commit to spack/spack that referenced this issue Nov 24, 2016

Bugfix/update go packages (#2369)
* Update go-bootstrap package

The last C based Go src tree was the 1.4 series.  For a while they
were cutting new releases so that people could bootstrap from a C only
system.  Now they're recommending that you either use the release-1.4
branch or that you use a date-stamped tarball that they'll produce on
an as-needed basis.

There are several issues that keep 1.4.2 from building on a CentOS 7
system.

I've switched to the date based tarball.

The cgo bits were also mis-behaving, but they're not needed for the
bootstrapping task so I've set an environment variable that disables
them.

Details [on the install-from-source
page](https://golang.org/doc/install/source#go14) and these issues:

- golang/go#17545
- golang/go#16352.

* Update go package

Switched from pulling from the git repository to using the source
tarballs and added digest values.

Added support for 1.7.3, continued supporting 1.6.2, including patches
for a couple of problems (details in
[17545](golang/go#17545) and
[17986](golang/go#17986).

Dropped support for 1.5.4 and 1.4.2 because they no longer pass their
tests and the patches above to not apply.

citibeth added a commit to citibeth/spack that referenced this issue Dec 4, 2016

Bugfix/update go packages (spack#2369)
* Update go-bootstrap package

The last C based Go src tree was the 1.4 series.  For a while they
were cutting new releases so that people could bootstrap from a C only
system.  Now they're recommending that you either use the release-1.4
branch or that you use a date-stamped tarball that they'll produce on
an as-needed basis.

There are several issues that keep 1.4.2 from building on a CentOS 7
system.

I've switched to the date based tarball.

The cgo bits were also mis-behaving, but they're not needed for the
bootstrapping task so I've set an environment variable that disables
them.

Details [on the install-from-source
page](https://golang.org/doc/install/source#go14) and these issues:

- golang/go#17545
- golang/go#16352.

* Update go package

Switched from pulling from the git repository to using the source
tarballs and added digest values.

Added support for 1.7.3, continued supporting 1.6.2, including patches
for a couple of problems (details in
[17545](golang/go#17545) and
[17986](golang/go#17986).

Dropped support for 1.5.4 and 1.4.2 because they no longer pass their
tests and the patches above to not apply.

grahamc referenced this issue in NixOS/nixpkgs Dec 28, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Sep 25, 2017

Change https://golang.org/cl/66073 mentions this issue: [release-branch.go1.4] time: Skip TestParseInLocation test.

gopherbot pushed a commit that referenced this issue Oct 3, 2017

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue #19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue #17545.

Updates #20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018

[release-branch.go1.4] time: skip TestLoadFixed on the Go 1.4 branch
Fixes golang#17545

Change-Id: I146e5e172174d8855289d173625ad0d115bc6ccc
Reviewed-on: https://go-review.googlesource.com/31855
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018

[release-branch.go1.4] time: skip TestLoadFixed on the Go 1.4 branch
Fixes golang#17545

Change-Id: I146e5e172174d8855289d173625ad0d115bc6ccc
Reviewed-on: https://go-review.googlesource.com/31855
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018

[release-branch.go1.4] time: skip TestLoadFixed on the Go 1.4 branch
Fixes golang#17545

Change-Id: I146e5e172174d8855289d173625ad0d115bc6ccc
Reviewed-on: https://go-review.googlesource.com/31855
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018

[release-branch.go1.4] time: skip TestLoadFixed on the Go 1.4 branch
Fixes golang#17545

Change-Id: I146e5e172174d8855289d173625ad0d115bc6ccc
Reviewed-on: https://go-review.googlesource.com/31855
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018

[release-branch.go1.4] time: skip TestLoadFixed on the Go 1.4 branch
Fixes golang#17545

Change-Id: I146e5e172174d8855289d173625ad0d115bc6ccc
Reviewed-on: https://go-review.googlesource.com/31855
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@golang golang locked and limited conversation to collaborators Sep 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.