Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: possible context leak in test #17560

Closed
josharian opened this issue Oct 23, 2016 · 1 comment
Closed

database/sql: possible context leak in test #17560

josharian opened this issue Oct 23, 2016 · 1 comment

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Oct 23, 2016

vet says:

database/sql/sql_test.go:269: the cancel function is not used on all paths (possible context leak)
database/sql/sql_test.go:320: this return statement may be reached without using the cancel var defined on line 269

Introduced in https://go-review.googlesource.com/c/29957/. It's just a test, but may as well do the right thing nevertheless.

@kardianos @bradfitz

@josharian josharian added this to the Go1.8 milestone Oct 23, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 23, 2016

CL https://golang.org/cl/31771 mentions this issue.

@quentinmit quentinmit added the NeedsFix label Oct 24, 2016
@gopherbot gopherbot closed this in 0fff67d Oct 24, 2016
@golang golang locked and limited conversation to collaborators Oct 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.