Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestCloseError fails on Plan 9 #17569

Closed
0intro opened this issue Oct 24, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@0intro
Copy link
Member

commented Oct 24, 2016

Since CL 30614, TestCloseError is failing on Plan 9.

--- FAIL: TestCloseError (0.01s)
    error_test.go:558: #1: unexpected type on 3rd nested level: *errors.errorString
    error_test.go:558: #2: unexpected type on 3rd nested level: *errors.errorString

See https://build.golang.org/log/f6de4a0fd8315d30b95079499787d7dc13a8dfe1

@0intro 0intro added the OS-Plan9 label Oct 24, 2016

@0intro 0intro added this to the Go1.8Maybe milestone Oct 24, 2016

@0intro 0intro self-assigned this Oct 24, 2016

@0intro

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2016

This error happens because the test in error_test.go:558 now returns the error:

close tcp 127.0.0.1:36858: write /net/tcp/clone: file already closed

Type: *errors.errorString

While it used to return the error:

close tcp 127.0.0.1:60474: write /net/tcp/clone: fd out of range or not open

Type: syscall.ErrorString

Because, there is now a f.fd == badFd check in File.Write before the write syscall, which returns the os.ErrClosed error.

@gopherbot

This comment has been minimized.

Copy link

commented Oct 24, 2016

CL https://golang.org/cl/31872 mentions this issue.

@gopherbot gopherbot closed this in 0c02280 Oct 24, 2016

@golang golang locked and limited conversation to collaborators Oct 24, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.