Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/goimports: #17576

Closed
deftworker opened this issue Oct 25, 2016 · 4 comments
Closed

x/tools/cmd/goimports: #17576

deftworker opened this issue Oct 25, 2016 · 4 comments

Comments

@deftworker
Copy link

@deftworker deftworker commented Oct 25, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.7

What operating system and processor architecture are you using (go env)?

mac

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

Try to run the newrelic go-agent plugin in Sublime Text with goimports and gosublime - since the plugin name is different from the package name, goimports keeps deleting it and making it impossible to use. I have to disable the automatic gosublime goimports functionality to use newrelic.

What did you expect to see?

Allow some plugins to be used even if they don't meet your naming conventions

What did you see instead?

Breaking behaviour.

@deftworker
Copy link
Author

@deftworker deftworker commented Oct 25, 2016

"github.com/newrelic/go-agent"

https://github.com/newrelic/go-agent

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 25, 2016

Sorry, I'm not going to fix this.

If you don't follow conventions, you don't get the tools which are built on conventions.

You'll have to write your imports by hand, I'm afraid.

@bradfitz bradfitz closed this Oct 25, 2016
@deftworker
Copy link
Author

@deftworker deftworker commented Oct 25, 2016

Reporting to newrelic as well.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 25, 2016

Thanks, please do.

goimports will respect any of these options:

package newrelic in github.com/newrelic/go-agent/newrelic
package agent in github.com/newrelic/go-agent
package goagent in github.com/newrelic/go-agent (after #17546 at least)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.