Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: no docs on "0" or empty name of transport service #17614

Closed
mikioh opened this issue Oct 26, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@mikioh
Copy link
Contributor

commented Oct 26, 2016

#13610 and CL 17755 fixed the behavior without documentation. There is no documentation that describes what happens when the zero value of transport service in Dial, Listen, ListenPacket functions and Resolve{TCP,UDP,IP}Addr functions. I guess those two groups behave differently.

@quentinmit quentinmit added the NeedsFix label Nov 1, 2016

@quentinmit quentinmit added this to the Go1.8Maybe milestone Nov 1, 2016

@mikioh

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2016

And Listen{TCP,UDP} functions.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 15, 2016

Guess this isn't happening. @mikioh, feel free to send something for Go 1.8, but otherwise I'm assuming this is Go 1.9 material. I would send a CL but I don't know what you want to say.

@bradfitz bradfitz modified the milestones: Go1.9, Go1.8Maybe Dec 15, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Jan 8, 2017

CL https://golang.org/cl/34875 mentions this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Jan 8, 2017

CL https://golang.org/cl/34876 mentions this issue.

@bradfitz bradfitz modified the milestones: Go1.9Maybe, Go1.9 Jun 13, 2017

@gopherbot gopherbot closed this in 7e63ce6 Jun 22, 2017

gopherbot pushed a commit that referenced this issue Jun 22, 2017

Mikio Hara
net: update documentation on Listen and ListenPacket
This change clarifies the documentation on Listen and ListenPacket to
avoid unnecessary confusion about how the arguments for the connection
setup functions are used to make connections.

Also replaces "name" or "hostname" with "host name" when the term
implies the use of DNS.

Updates #17613.
Updates #17614.
Updates #17615.
Fixes #17616.
Updates #17738.
Updates #17956.

Change-Id: I0bad2e143207666f2358d397fc076548ee6c3ae9
Reviewed-on: https://go-review.googlesource.com/34876
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@golang golang locked and limited conversation to collaborators Jun 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.