Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: no docs about the consecutive dialing introduced in Go 1.5 #17617

Closed
mikioh opened this issue Oct 26, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@mikioh
Copy link
Contributor

commented Oct 26, 2016

The release notes of Go 1.5, https://golang.org/doc/go1.5, say:

The net package will now Dial hostnames by trying each IP address in order until one succeeds. 

but there is no documentation about the behavior in net package.

@quentinmit quentinmit added the NeedsFix label Nov 1, 2016

@quentinmit quentinmit added this to the Go1.8Maybe milestone Nov 1, 2016

@quentinmit

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2016

Especially important is documenting how timeouts are handled by this algorithm.

@kavirajk

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2016

@quentinmit do you mean about calcularing partialDeadline for single address when multiple addresses are pending?

@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 30, 2016

@mikioh, are you going to write something?

@mikioh

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2016

@bradfitz,

Will do if no one wants to do, but it will start from the end of this month. Happy to review a CL.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 1, 2016

You have about 20 days before we probably won't accept even a doc change.

@kavirajk

This comment has been minimized.

Copy link
Contributor

commented Dec 2, 2016

after walking through the Dial function, I feel llike we have to document two things.

  1. Dial method. If a hostname have multiple IP addresses, each one of the them is tried in order until first one succeed

  2. dialSerial method. How partialDeadline is calculated from actual deadline, for dialing each IP-address based on total number of IP addresses for the hostname.

correct me if I'm wrong or If I am missing anything, I am happy to raise CL.

/cc @mikioh @quentinmit @bradfitz

@gopherbot

This comment has been minimized.

Copy link

commented Dec 13, 2016

CL https://golang.org/cl/34176 mentions this issue.

@gopherbot gopherbot closed this in 79a748f Dec 14, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Dec 14, 2016

CL https://golang.org/cl/34376 mentions this issue.

gopherbot pushed a commit that referenced this issue Dec 15, 2016

net: fix consecutive dialing docs
Update #17617.

Change-Id: Ia0bc9954bb914b650b7c7af35ef714ca6b0740b4
Reviewed-on: https://go-review.googlesource.com/34376
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@golang golang locked and limited conversation to collaborators Dec 14, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.