New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: wrong import stack in error message #17648

Open
rsc opened this Issue Oct 28, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@rsc
Contributor

rsc commented Oct 28, 2016

This is not true:

$ go get -u rsc.io/github/issue
package rsc.io/github/issue
    imports 9fans.net/go/acme
    imports 9fans.net/go/plan9
    imports 9fans.net/go/plan9/client
    imports 9fans.net/go/draw
    imports 9fans.net/go/draw/drawfcall
    imports github.com/google/go-github/github
    imports github.com/google/go-querystring/query
    imports golang.org/x/net/context: exit status 1
... error about x/net checkout being in a bad state ...

It looks like imports are being pushed on the import stack and not being popped correctly. rsc.io/github/issue imports github.com/google/go-github/github directly. 9fans.net/go/draw/drawfcall does not.

@rsc rsc added this to the Go1.8 milestone Oct 28, 2016

@rsc rsc added the NeedsFix label Oct 28, 2016

@rsc rsc modified the milestones: Go1.9, Go1.8 Nov 11, 2016

@odeke-em

This comment has been minimized.

Member

odeke-em commented Jul 6, 2017

Hello @rsc, any new thoughts on this issue?

Currently on tip at b5240da, I get back

$ go get -u rsc.io/github/issue
# rsc.io/github/issue
../go/src/rsc.io/github/issue/acme.go:279:33: not enough arguments in call to client.Issues.Edit
	have (string, string, int, *github.IssueRequest)
	want ("context".Context, string, string, int, *github.IssueRequest)
../go/src/rsc.io/github/issue/edit.go:152:40: not enough arguments in call to client.Issues.Create
	have (string, string, *github.IssueRequest)
	want ("context".Context, string, string, *github.IssueRequest)
../go/src/rsc.io/github/issue/edit.go:181:43: not enough arguments in call to client.Issues.CreateComment
	have (string, string, int, *github.IssueComment)
	want ("context".Context, string, string, int, *github.IssueComment)
../go/src/rsc.io/github/issue/edit.go:193:34: not enough arguments in call to client.Issues.Edit
	have (string, string, int, *github.IssueRequest)
	want ("context".Context, string, string, int, *github.IssueRequest)
../go/src/rsc.io/github/issue/edit.go:202:46: not enough arguments in call to client.Issues.AddLabelsToIssue
	have (string, string, int, []string)
	want ("context".Context, string, string, int, []string)
../go/src/rsc.io/github/issue/edit.go:216:47: not enough arguments in call to client.Issues.RemoveLabelForIssue
	have (string, string, int, string)
	want ("context".Context, string, string, int, string)
../go/src/rsc.io/github/issue/edit.go:465:13: client.Rate undefined (type *github.Client has no field or method Rate)
../go/src/rsc.io/github/issue/edit.go:466:20: client.Rate undefined (type *github.Client has no field or method Rate)
../go/src/rsc.io/github/issue/edit.go:472:26: client.RateLimit undefined (type *github.Client has no field or method RateLimit)
../go/src/rsc.io/github/issue/issue.go:347:36: not enough arguments in call to client.Issues.Get
	have (string, string, int)
	want ("context".Context, string, string, int)
../go/src/rsc.io/github/issue/issue.go:347:36: too many errors

which is very noisy with errors, to help me reproduce your issue properly.

@rsc rsc modified the milestones: Go1.10, Go1.9 Jul 6, 2017

@rsc

This comment has been minimized.

Contributor

rsc commented Jul 6, 2017

Not important / too easy to introduce new bugs for Go 1.9. Moving to Go 1.10.

@odeke-em, I got as far as you did a while back and made it halfway through updating rsc.io/github/issue but then stopped. Haven't gotten back to it. Thanks for looking though.

@rsc rsc modified the milestones: Go1.10, Go1.11 Dec 1, 2017

@gopherbot gopherbot modified the milestones: Go1.11, Unplanned May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment