Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/sha256: improve performance on ppc64le for sha256.block #17652

Closed
laboger opened this issue Oct 28, 2016 · 2 comments
Closed

crypto/sha256: improve performance on ppc64le for sha256.block #17652

laboger opened this issue Oct 28, 2016 · 2 comments

Comments

@laboger
Copy link
Contributor

@laboger laboger commented Oct 28, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

tip

What operating system and processor architecture are you using (go env)?

Ubuntu 16.04

We have an asm version of sha256.block for ppc64le to improve performance.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 28, 2016

CL https://golang.org/cl/32318 mentions this issue.

Loading

@mstrosaker
Copy link

@mstrosaker mstrosaker commented Oct 28, 2016

The assembly implementation was submitted here:
https://go-review.googlesource.com/32318

Loading

@gopherbot gopherbot closed this in 7b50bd8 Oct 31, 2016
ceseo added a commit to powertechpreview/go that referenced this issue Dec 1, 2016
Adds an assembly implementation of sha256.block for ppc64le to improve its
performance.  This implementation is largely based on the original amd64
implementation, which unrolls the 64 iterations of the inner loop.

Fixes golang#17652

benchmark               old ns/op     new ns/op     delta
BenchmarkHash8Bytes     1263          767           -39.27%
BenchmarkHash1K         14048         7766          -44.72%
BenchmarkHash8K         102245        55626         -45.60%

benchmark               old MB/s     new MB/s     speedup
BenchmarkHash8Bytes     6.33         10.43        1.65x
BenchmarkHash1K         72.89        131.85       1.81x
BenchmarkHash8K         80.12        147.27       1.84x

Change-Id: Ib4adf429423b20495580400be10bd7e171bcc70b
Reviewed-on: https://go-review.googlesource.com/32318
Reviewed-by: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants