Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: Info needs a new map, AliasUses map[*types.Ident]*types.Alias #17706

Closed
alandonovan opened this issue Oct 31, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@alandonovan
Copy link
Contributor

@alandonovan alandonovan commented Oct 31, 2016

Refactoring tools such as eg, gorename, and bundle need access to the precise relationship between references and declarations. Before Go 1.8 the Defs and Uses maps sufficed, but with the introduction of aliases, it's impossible to distinguish a reference to an alias from a reference to the alias's "original" object.

I propose that we add another optional map to types.Info:

    AliasUses map[*types.Ident]*types.Alias
@alandonovan alandonovan added this to the Go1.8 milestone Oct 31, 2016
@alandonovan
Copy link
Contributor Author

@alandonovan alandonovan commented Nov 1, 2016

I no longer think this is necessary; see comments in CL https://go-review.googlesource.com/c/32108/.

Loading

@alandonovan alandonovan closed this Nov 1, 2016
@golang golang locked and limited conversation to collaborators Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants