Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/acme/autocert: lock usage around certState is bogus and error prone #17749

Open
niemeyer opened this issue Nov 2, 2016 · 1 comment

Comments

@niemeyer
Copy link
Contributor

commented Nov 2, 2016

The use of locks around certState is pretty confusing. The certState method returns the state value either locked or not, which means the call site has no idea about what it got. Then, there's a locked boolean field which is used to decide whether to lock it again or release the existing lock. That's both error prone and wrong from a concurrent memory access perspective.

@dsnet dsnet added this to the Unreleased milestone Nov 3, 2016

@gopherbot

This comment has been minimized.

Copy link

commented May 2, 2017

CL https://golang.org/cl/41731 mentions this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.