Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestServerSetKeepAlivesEnabledClosesConns flaking with "idle count after SetKeepAlivesEnabled called = 1; want 0" #17754

mdempsky opened this issue Nov 2, 2016 · 2 comments


Copy link

@mdempsky mdempsky commented Nov 2, 2016

Seen several times today on trybots:

Failed on linux-amd64:
Failed on openbsd-amd64-gce58:
Failed on windows-amd64-gce:

/cc @bradfitz

Copy link

@gopherbot gopherbot commented Nov 3, 2016

CL mentions this issue.

@gopherbot gopherbot closed this in be7c50a Nov 3, 2016
Copy link

@gopherbot gopherbot commented Nov 11, 2016

CL mentions this issue.

gopherbot pushed a commit that referenced this issue Nov 11, 2016
If the Server's Shutdown (or SetKeepAlivesEnabled) method was called
while a connection was in a Handler, but after the headers had been
written, the connection was not later closed.

Fixes #9478
Updates #17754 (reverts that workaround)

Change-Id: I65324ab8217373fbb38e12e2b8bffd0a91806072
Reviewed-by: Ian Lance Taylor <>
@golang golang locked and limited conversation to collaborators Nov 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.