Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestServerSetKeepAlivesEnabledClosesConns flaking with "idle count after SetKeepAlivesEnabled called = 1; want 0" #17754

Closed
mdempsky opened this issue Nov 2, 2016 · 2 comments

Comments

Assignees

@bradfitz bradfitz

Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.8
3 participants
@mdempsky @gopherbot @bradfitz
@mdempsky

@bradfitz bradfitz self-assigned this Nov 2, 2016

@bradfitz bradfitz added this to the Go1.8 milestone Nov 2, 2016

@bradfitz bradfitz referenced this issue Nov 3, 2016

Closed

net/http: make Server.SetKeepAlivesEnabled(false) drop currently-open connections #9478

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 3, 2016

CL https://golang.org/cl/32587 mentions this issue.

@gopherbot gopherbot closed this in be7c50a Nov 3, 2016

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 11, 2016

CL https://golang.org/cl/33141 mentions this issue.

gopherbot pushed a commit that referenced this issue Nov 11, 2016

@bradfitz
net/http: make Server respect shutdown state after handler finishes 
If the Server's Shutdown (or SetKeepAlivesEnabled) method was called
while a connection was in a Handler, but after the headers had been
written, the connection was not later closed.

Fixes #9478
Updates #17754 (reverts that workaround)

Change-Id: I65324ab8217373fbb38e12e2b8bffd0a91806072
Reviewed-on: https://go-review.googlesource.com/33141
Reviewed-by: Ian Lance Taylor <iant@golang.org>
9f9d834

@golang golang locked and limited conversation to collaborators Nov 11, 2017

@gopherbot gopherbot added the FrozenDueToAge label Nov 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.