Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: TestServerSetKeepAlivesEnabledClosesConns flaking with "idle count after SetKeepAlivesEnabled called = 1; want 0" #17754
Comments
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/32587 mentions this issue. |
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/33141 mentions this issue. |
gopherbot
pushed a commit
that referenced
this issue
Nov 11, 2016
If the Server's Shutdown (or SetKeepAlivesEnabled) method was called while a connection was in a Handler, but after the headers had been written, the connection was not later closed. Fixes #9478 Updates #17754 (reverts that workaround) Change-Id: I65324ab8217373fbb38e12e2b8bffd0a91806072 Reviewed-on: https://go-review.googlesource.com/33141 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Seen several times today on trybots:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/8b2acc47/linux-amd64_eefbc2f7.log
Failed on openbsd-amd64-gce58: https://storage.googleapis.com/go-build-log/8b2acc47/openbsd-amd64-gce58_5cfee96b.log
Failed on windows-amd64-gce: https://storage.googleapis.com/go-build-log/8a2800a1/windows-amd64-gce_c6ab9d3e.log
/cc @bradfitz