Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/net/http2: server ignores GOAWAY #17800
processFrame doesn't handle GOAWAY:
Firefox apparently sends GOAWAY after a connection is idle, but this frame is ignored by our http2 server. With VerboseLogs=true, I see:
Is this intentional?
I just reread Section 6.8. The main effects of GOAWAY are: (a) it tells the peer which requests have been processed, and (b) it stops the peer from creating new requests (so the connection eventually quiesces and shuts down gracefully).
(a) is only meaningful when the server tells the client to GOAWAY (so the client knows which POSTs were handled). (b) means the server shouldn't send new pushes. So maybe the only effect is that the server should disable push upon receiving a GOAWAY?
I agree this doesn't seem very important.