Skip to content

x/review/git-codereview: handle many-parent merges in hooks #17861

@josharian

Description

@josharian

When running the git-codereview hooks on a commit that is (soon to be a child of) a merge of three branches, I get:

$ git commit
git branch -a --contains 3c49c114ba9e7292b342230a0b238d4684157d2b fce0592992d48cbd5e7ca44724f3f14ee25c0f05
error: malformed object name 3c49c114ba9e7292b342230a0b238d4684157d2b fce0592992d48cbd5e7ca44724f3f14ee25c0f05

...
git-codereview: exit status 129

Low priority to fix, but an annoyance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions