net/http: test race on linux/amd64 trybot #17868
Closed
Comments
/cc @bradfitz |
Well, that's frickin' useless. |
$ GORACE="atexit_sleep_ms=0 history_size=7" stress -failure="DATA RACE" -p 16 ./http.test -test.short gives full report in a minute:
|
CL https://golang.org/cl/33013 mentions this issue. |
@bradfitz hello, just came across panic that most probably caused by this issue. I am a bit lost - why data race fix like this have not been included into go1.7.5? Should we use |
You can wait two days for Go 1.8 final. |
c3mb0
pushed a commit
to c3mb0/net
that referenced
this issue
Apr 2, 2018
Fixes golang/go#17868 Change-Id: I7f9d85f404198d68757d7ca5bb8b1e7aafaafa8b Reviewed-on: https://go-review.googlesource.com/33013 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tom Bergan <tombergan@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I see a race on the linux-amd64-race trybot running over some unrelated code (CL 32923):
https://storage.googleapis.com/go-build-log/17537d3e/linux-amd64-race_d3fd3644.log
I see that there are some recent test-flake-related commits in net/http but I cannot reproduce the race locally within a few
test -race
runs so I don't know whether it's fixed or not.The text was updated successfully, but these errors were encountered: