-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: implement closeRead and closeWrite on Plan 9 #17906
Comments
CL https://golang.org/cl/35178 mentions this issue. |
CL https://golang.org/cl/35179 mentions this issue. |
CL 35234 added TestServerHijackGetsBackgroundByte_big, which is failing on Plan 9, because CloseWrite is not implemented on Plan 9 yet. Updates #17906. Updates #18658. Change-Id: Icaf3fe3600d586515ecd92aca874104ea81ce6b9 Reviewed-on: https://go-review.googlesource.com/35179 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
CL 5232 added TestServerHijackGetsBackgroundByte, which is failing on Plan 9, because CloseWrite is not implemented on Plan 9 yet. Updates #17906. Updates #18657. Change-Id: I3c2f73760b0f767f3f9ed2698c855372170e0481 Reviewed-on: https://go-review.googlesource.com/35178 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
I'm marking this as Unplanned but David, feel free to implement whenever you want, regardless of release cycle, as long as it only touches plan9 files or removes t.Skip calls. |
Change https://golang.org/cl/121735 mentions this issue: |
Issues #10043, #15405, and #22660 appear to have been fixed, and whatever tests I could run locally do succeed, so remove the skips. Issue #7237 was closed in favor of #17906, so update its skip line. Issue #7634 was closed as it had not appeared for over three years. Re-enable it for now. An issue should be open if the test starts being skipped again. Change-Id: I67daade906744ed49223291035baddaad9f56dca Reviewed-on: https://go-review.googlesource.com/121735 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Change https://golang.org/cl/209417 mentions this issue: |
@0intro, does Plan 9 even support half closed TCP connections? |
This stops the tests from hanging on Plan 9. Fixes golang/go#35904 Updates golang/go#17906 Change-Id: I2bcbb131629b217a99f9496cda0399ce21eb3020 Reviewed-on: https://go-review.googlesource.com/c/net/+/209417 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz Nope. There was some 9fans discussion some years ago about adding support for it in the Plan 9 kernel, and there is a kernel patch but it hasn't been merged yet. |
This is interesting. I didn't remember this change. I'll try it and eventually merge it. |
Change https://golang.org/cl/224217 mentions this issue: |
Updates bundled http2 to x/net git rev 63522dbf7 http2: reduce allocations of (*clientConnReadLoop).handleReponse https://golang.org/cl/223783 (#37853) http2: remove unused errors https://golang.org/cl/220458 http2: remove unused stream struct fields https://golang.org/cl/219857 http2: fix typo in comment https://golang.org/cl/214602 http2: workaround TCPConn CloseWrite not being supported on Plan 9 https://golang.org/cl/209417 (#17906, #35904) Change-Id: I0e48f32247938c3858170bf419624367d4faef4b Reviewed-on: https://go-review.googlesource.com/c/go/+/224217 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Change https://golang.org/cl/235217 mentions this issue: |
In TestTransportPingWhenReading, a TCP half-close was being used, which isn't supported in the Plan 9 kernel. The workaround is to call (*TCPConn).Close when running on Plan 9. See golang/go#17906 Fixes golang/go#39233 Change-Id: Ifb2934621fb53d76a3b161b239c438c13f8c508e Reviewed-on: https://go-review.googlesource.com/c/net/+/235217 Reviewed-by: David du Colombier <0intro@gmail.com> Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
This stops the tests from hanging on Plan 9. Fixes golang/go#35904 Updates golang/go#17906 Change-Id: I2bcbb131629b217a99f9496cda0399ce21eb3020 Reviewed-on: https://go-review.googlesource.com/c/net/+/209417 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
In TestTransportPingWhenReading, a TCP half-close was being used, which isn't supported in the Plan 9 kernel. The workaround is to call (*TCPConn).Close when running on Plan 9. See golang/go#17906 Fixes golang/go#39233 Change-Id: Ifb2934621fb53d76a3b161b239c438c13f8c508e Reviewed-on: https://go-review.googlesource.com/c/net/+/235217 Reviewed-by: David du Colombier <0intro@gmail.com> Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
We should implement closeRead and closeWrite on Plan 9, so the following tests could be enabled:
The text was updated successfully, but these errors were encountered: