Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: implement closeRead and closeWrite on Plan 9 #17906

Open
0intro opened this issue Nov 13, 2016 · 4 comments

Comments

Assignees

@0intro 0intro

Labels
OS-Plan9
Projects
None yet
Milestone
  Unplanned
3 participants
@0intro @gopherbot @bradfitz
@0intro
Copy link
Member

commented Nov 13, 2016

We should implement closeRead and closeWrite on Plan 9, so the following tests could be enabled:

  • TestCloseRead
  • TestCloseWrite
  • TestClientWriteShutdown (net/http package, see #7237)

@0intro 0intro added the OS-Plan9 label Nov 13, 2016

@0intro 0intro added this to the Go1.8Early milestone Nov 13, 2016

@0intro 0intro self-assigned this Nov 13, 2016

@bradfitz bradfitz modified the milestones: Go1.9Early, Go1.8Early Nov 14, 2016

@bradfitz bradfitz referenced this issue Jan 6, 2017

Closed

net/http: failing tests on Plan 9 #7237

@0intro 0intro referenced this issue Jan 14, 2017

Open

net/http: TestServerHijackGetsBackgroundByte failing on Plan 9 #18657

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 14, 2017

CL https://golang.org/cl/35178 mentions this issue.

@0intro 0intro referenced this issue Jan 14, 2017

Open

net/http: TestServerHijackGetsBackgroundByte_big failing on Plan 9 #18658

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 14, 2017

CL https://golang.org/cl/35179 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 14, 2017

@0intro @bradfitz
net/http: skip TestServerHijackGetsBackgroundByte_big on Plan 9 
CL 35234 added TestServerHijackGetsBackgroundByte_big, which is failing
on Plan 9, because CloseWrite is not implemented on Plan 9 yet.

Updates #17906.
Updates #18658.

Change-Id: Icaf3fe3600d586515ecd92aca874104ea81ce6b9
Reviewed-on: https://go-review.googlesource.com/35179
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
e395e32

gopherbot pushed a commit that referenced this issue Jan 14, 2017

@0intro @bradfitz
net/http: skip TestServerHijackGetsBackgroundByte on Plan 9 
CL 5232 added TestServerHijackGetsBackgroundByte, which is failing
on Plan 9, because CloseWrite is not implemented on Plan 9 yet.

Updates #17906.
Updates #18657.

Change-Id: I3c2f73760b0f767f3f9ed2698c855372170e0481
Reviewed-on: https://go-review.googlesource.com/35178
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
76f981c

@bradfitz bradfitz modified the milestones: Unplanned, Go1.9Early May 3, 2017

@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 3, 2017

I'm marking this as Unplanned but David, feel free to implement whenever you want, regardless of release cycle, as long as it only touches plan9 files or removes t.Skip calls.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 29, 2018

Change https://golang.org/cl/121735 mentions this issue: all: update stale test skips

gopherbot pushed a commit that referenced this issue Aug 20, 2018

@mvdan
all: update stale test skips 
Issues #10043, #15405, and #22660 appear to have been fixed, and
whatever tests I could run locally do succeed, so remove the skips.

Issue #7237 was closed in favor of #17906, so update its skip line.

Issue #7634 was closed as it had not appeared for over three years.
Re-enable it for now. An issue should be open if the test starts being
skipped again.

Change-Id: I67daade906744ed49223291035baddaad9f56dca
Reviewed-on: https://go-review.googlesource.com/121735
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
9e4d87d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.