Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: Cannot handle javap error message with non-English environment #17987

Closed
tenntenn opened this issue Nov 19, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@tenntenn
Copy link
Contributor

commented Nov 19, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.7.3 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/tenntenn/Documents/gopath"
GORACE=""
GOROOT="/usr/local/go1.7"
GOTOOLDIR="/usr/local/go1.7/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/mq/m9_twy8j1vl9ppr6j5xqtfq80000gn/T/go-build135510012=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

With my Japanese environment, javap report errors in Japanese.

$ /usr/bin/javap -s -protected -constants com.example.ExampleClass
エラー: クラスが見つかりません: com.example.ExampleClass

But java.Importer.Import handles errors using javap's output in English.
So javap should be called with -J-Duser.language=en option.

What did you expect to see?

Successfully build.

What did you see instead?

Build error.

@gopherbot

This comment has been minimized.

Copy link

commented Nov 19, 2016

CL https://golang.org/cl/33371 mentions this issue.

@quentinmit quentinmit added the NeedsFix label Nov 21, 2016

@quentinmit quentinmit added this to the Unreleased milestone Nov 21, 2016

@golang golang locked and limited conversation to collaborators Nov 21, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.