Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: TestLoadFixed fails on 1.7.3 source build #18064

Closed
karalabe opened this issue Nov 27, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@karalabe
Copy link
Contributor

commented Nov 27, 2016

I've just set up a new machine and wanted to build Go and was surprised to see that 1.7.3 compilation always fail on a time test. My build procedure is as follows:

  • (My OS is Ubuntu Yakkety)
  • Download Go 1.7.3 for Linux amd64 and set it up as GOROOT-BOOTSTRAP
  • Clone the upstream Go repository
  • Checkout go1.7.3 (latest commit at 2f6557233c5a5c311547144c34b4045640ff9f71)
  • Run all.bash from the src folder

This results in:

--- FAIL: TestLoadFixed (0.00s)
	time_test.go:943: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600
FAIL
FAIL	time	2.439s
@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 27, 2016

Dup of #17276, fixed by c5434f2

You can ignore that test failure. It's caused by an updated tzdata that came out after that version of Go was released. It'll be fixed in Go 1.8.

@bradfitz bradfitz closed this Nov 27, 2016

@karalabe

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2016

@golang golang locked and limited conversation to collaborators Nov 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.