Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: min-width instead of width #18091

Closed
ajackson-cpi opened this issue Nov 29, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@ajackson-cpi
Copy link

commented Nov 29, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.7

What operating system and processor architecture are you using (go env)?

All

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

https://godoc.org/github.com/nicksnyder/go-i18n/goi18n
http://instantshare.virtivia.com:27080/4r28fpq4btj0.mov

package foo
/*
Doc Problem:
Any GoDoc formatted section (which is indented in the code) that becomes very long has the problem of a UI treatment that produces a scrollbar if the line goes on for too long. What's worse is if the formatted section is over a page tall, then the user must navigate to the end of the section to scroll.
*/

What did you expect to see?

The format box should have expanded to use more available screen space on both sides of the hard-coded width.

What did you see instead?

A hard-coded width (100 chars?) is imposed and longer test needs left-right scroll. The left-right scrollbar could be off the end of the page if the section of code is long enough making the document experience that shows example code a painful experience.

Suggestion: Widths for GoDoc should use min-width instead of width and allow growth.

@bradfitz bradfitz changed the title GoDoc min-width instead of width. x/tools/cmd/godoc: min-width instead of width Nov 29, 2016

@bradfitz bradfitz added this to the Go1.9Maybe milestone Nov 29, 2016

@broady

This comment has been minimized.

Copy link
Member

commented Nov 29, 2016

This isn't a problem for godoc itself, it's specific to godoc.org:
golang/gddo#458

@broady broady closed this Nov 29, 2016

@golang golang locked and limited conversation to collaborators Nov 29, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.