Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: document Client's new header copying behavior #18096

Closed
bradfitz opened this issue Nov 29, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@bradfitz
Copy link
Member

commented Nov 29, 2016

The http Client's new copy-headers-on-redirect behavior is not documented.

It should probably be added to https://tip.golang.org/pkg/net/http/#Client.Do and/or https://tip.golang.org/pkg/net/http/#Client with maybe a pointer to its canonical documentation location from the CheckRedirect field.

@dsnet, can you write this? Otherwise reassign to me if you're swamped.

@bradfitz bradfitz added this to the Go1.8 milestone Nov 29, 2016

@bradfitz bradfitz changed the title net/http: document Client's new cop net/http: document Client's new header copying behavior Nov 29, 2016

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Nov 29, 2016

And then update go1.8.html which now has a reference to this bug.

@quentinmit quentinmit added the NeedsFix label Nov 29, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Nov 29, 2016

CL https://golang.org/cl/33670 mentions this issue.

@gopherbot gopherbot closed this in feacaca Nov 30, 2016

@golang golang locked and limited conversation to collaborators Nov 30, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.