Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/ast: GenDecl documentation mistake? #18109

Closed
bradfitz opened this issue Nov 29, 2016 · 2 comments
Closed

go/ast: GenDecl documentation mistake? #18109

bradfitz opened this issue Nov 29, 2016 · 2 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 29, 2016

https://golang.org/pkg/go/ast/#GenDecl says:

A valid Lparen position (Lparen.Line > 0) indicates a parenthesized declaration.

But LParent is a https://golang.org/pkg/go/token/#Pos which is just an int. It doesn't have a "Line" field.

@bradfitz bradfitz added this to the Go1.8Maybe milestone Nov 29, 2016
@griesemer
Copy link
Contributor

@griesemer griesemer commented Nov 29, 2016

Yes, the documentation is broken. Will fix.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 29, 2016

CL https://golang.org/cl/33669 mentions this issue.

@gopherbot gopherbot closed this in 6eb11b2 Nov 29, 2016
@golang golang locked and limited conversation to collaborators Nov 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.