Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: document Request.Context's lifetime again #18143

Closed
bradfitz opened this issue Dec 1, 2016 · 2 comments
Closed

net/http: document Request.Context's lifetime again #18143

bradfitz opened this issue Dec 1, 2016 · 2 comments
Assignees
@bradfitz
Labels
Documentation FrozenDueToAge
Milestone
Go1.8

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 1, 2016

It was originally documented as closing when the peer closed for Go 1.7, but then we removed that part of the docs when the implementation wasn't complete.

The implementation is complete in Go 1.8, so we need to add the docs back.
@bradfitz bradfitz added this to the Go1.8 milestone Dec 1, 2016
@bradfitz bradfitz self-assigned this Dec 1, 2016
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@bradfitz bradfitz commented Dec 1, 2016

(Original revert was 15db365)
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Dec 1, 2016

CL https://golang.org/cl/33769 mentions this issue.
@gopherbot gopherbot closed this in 208d4d2 Dec 1, 2016
@golang golang locked and limited conversation to collaborators Dec 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradfitz bradfitz

Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
  Go1.8
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bradfitz @gopherbot
You can’t perform that action at this time.