Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: stack growth needs to adjust frame pointer #18174

Closed
randall77 opened this issue Dec 2, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@randall77
Copy link
Contributor

commented Dec 2, 2016

We're currently adjusting frame pointers that are on the stack. But we aren't adjusting the one that's in gp.sched.bp during stack growth. That frame pointer then gets written to the stack after the growth is done (by the prologue of the function that triggered stack growth).
We need to adjust that last frame pointer to get the frame linking correct.

@aclements

@randall77 randall77 added this to the Go1.8 milestone Dec 2, 2016

@randall77 randall77 self-assigned this Dec 2, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Dec 2, 2016

CL https://golang.org/cl/33895 mentions this issue.

@gopherbot gopherbot closed this in 1ea60c1 Dec 7, 2016

@golang golang locked and limited conversation to collaborators Dec 7, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.