Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: fix comments on ParseCIDR #18175

Closed
mikioh opened this issue Dec 2, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@mikioh
Copy link
Contributor

commented Dec 2, 2016

The comments on ParseCIDR use the wrong word mask instead of prefix length like the following:
ParseCIDR parses s as a CIDR notation IP address and mask. Documentation is hard.

@mikioh mikioh added the Documentation label Dec 2, 2016

@mikioh mikioh added this to the Go1.8Maybe milestone Dec 2, 2016

@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 5, 2016

Not a regression from previous releases. Feel free to send a CL if you'd like any time. It can go in 1.8 if it's just docs.

@bradfitz bradfitz modified the milestones: Unplanned, Go1.8Maybe Dec 5, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Dec 14, 2016

CL https://golang.org/cl/34375 mentions this issue.

@gopherbot gopherbot closed this in 232991e Dec 14, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Dec 15, 2016

CL https://golang.org/cl/34431 mentions this issue.

@mikioh mikioh removed their assignment Dec 15, 2016

gopherbot pushed a commit that referenced this issue Dec 15, 2016

Mikio Hara
net: fix ParseCIDR docs
This change replaces the remaining use of "mask" with "prefix length"
and uses IPv4 reserved address blocks for documentation.

UPdates #15228.
Updates #18175.

Change-Id: I56c4f1205821c64f3195b023ad515b9d54e33f64
Reviewed-on: https://go-review.googlesource.com/34431
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@golang golang locked and limited conversation to collaborators Dec 15, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.