Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: fix comment on IPv4bcast #18176

Closed
mikioh opened this issue Dec 2, 2016 · 3 comments
Closed

net: fix comment on IPv4bcast #18176

mikioh opened this issue Dec 2, 2016 · 3 comments
Labels
Documentation FrozenDueToAge
Milestone
Unplanned

Comments

@mikioh
Copy link
Contributor

@mikioh mikioh commented Dec 2, 2016

The comment says IPv4bcast = IPv4(255, 255, 255, 255) // broadcast, but it's a limited broadcast address and should be distinguished from directed broadcast addresses.
@mikioh mikioh added the Documentation label Dec 2, 2016
@mikioh mikioh added this to the Go1.8Maybe milestone Dec 2, 2016
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 2, 2016

Just send a CL if there's a one-word fix.

But I don't think anything is needed here. If people are looking for 255.255.255.255, they found it. Otherwise they didn't.
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 3, 2016

Not a regression from any Go release, so removing the Go 1.8 label. Feel free to send a CL if you have something succinct and okay for end users and not networking experts.
@bradfitz bradfitz modified the milestones: Unplanned, Go1.8Maybe Dec 3, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 15, 2016

CL https://golang.org/cl/34435 mentions this issue.
@gopherbot gopherbot closed this in 34bd7d5 Dec 15, 2016
@golang golang locked and limited conversation to collaborators Dec 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bradfitz @mikioh @gopherbot