Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
unicode: FoldCategory and FoldScript incorrectly defined #18186
In Go version 1.7.3, the unicode package provides 2 maps: FoldCategory and FoldScript. FoldCategory is only supposed to map category names to tables of code points, but includes script names ("Common", "Greek", "Inherited"). By contrast, although FoldScript is supposed to map script names to tables of code points, the 3 script names ("Common", "Greek", "Inherited") are missing and FoldScript is an empty map.
This bug could be fixed by instead defining Fold Category and FoldScript thus:
This much better fits what the user of unicode expects when reading the descriptions of FoldCategory and FoldScript (as well as better matching what the names of the variables imply).
Seems like @mpvl is away (not sure). I'll take care of this. I thought the tables were now generated from something in x/text, but unicode/maketables.go is still in the main distribution and editing and rerunning it has the desired effect, so good enough for me.