Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
test: doesn't use GO_GCFLAGS for tests #18222
GO_GCFLAGS only affects the compiler that is invoked directly by the
Maybe this is unfixable as a some of the tests in test/ provide their own flags to the compiler. But it surprised me that the ssacheck checks weren't actually running on the ssacheck builder in the test directory.
Maybe there's some way to propagate GO_GCFLAGS that makes sense.
See https://go-review.googlesource.com/c/33909/ for a hack I needed to make this work for randomized value order testing.
I think this might be so, in the general case. Some flags are incompatible with others in non-trivial ways (which is why cmd/go is such a bear). And the test dir generally probes the weirdest cases we can find.
I'm inclined towards adding hacks to test/run.go to solve particular problems instead, like the hack+problem in CL 33909.