Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: doesn't use GO_GCFLAGS for tests #18222

Open
randall77 opened this issue Dec 7, 2016 · 2 comments

Comments

@randall77
Copy link
Contributor

commented Dec 7, 2016

GO_GCFLAGS only affects the compiler that is invoked directly by the dist tool (I think).
The compiler invoked by test/run.go doesn't have its command line modified by GO_GCFLAGS.
So all of the tests in test/ aren't actually testing what we think they are testing on the modified builders like noopt and ssacheck.

Maybe this is unfixable as a some of the tests in test/ provide their own flags to the compiler. But it surprised me that the ssacheck checks weren't actually running on the ssacheck builder in the test directory.

Maybe there's some way to propagate GO_GCFLAGS that makes sense.

See https://go-review.googlesource.com/c/33909/ for a hack I needed to make this work for randomized value order testing.

@bradfitz @cherrymui @dr2chase

@bradfitz bradfitz added this to the Go1.9 milestone Dec 7, 2016

@bradfitz bradfitz added the Builders label Dec 7, 2016

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 24, 2017

@josharian

This comment has been minimized.

Copy link
Contributor

commented May 24, 2017

Maybe this is unfixable as a some of the tests in test/ provide their own flags to the compiler.

I think this might be so, in the general case. Some flags are incompatible with others in non-trivial ways (which is why cmd/go is such a bear). And the test dir generally probes the weirdest cases we can find.

I'm inclined towards adding hacks to test/run.go to solve particular problems instead, like the hack+problem in CL 33909.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9 Jun 7, 2017

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Dec 7, 2017

@gopherbot gopherbot modified the milestones: Go1.11, Unplanned May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.