Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/internal/gccgoimporter: import control function v2 format not properly parsed #18301

Closed
stjj89 opened this issue Dec 13, 2016 · 2 comments
Closed
Milestone

Comments

@stjj89
Copy link
Contributor

@stjj89 stjj89 commented Dec 13, 2016

The follow sequence of import control function list in time.gox:

init time time..import runtime runtime..import sync sync..import syscall syscall..import;

results in the following gccgoimporter error while it is being parsed:

import error time:7:31 (byte offset = 152): expected Int, got Ident (runtime))

gccgoimporter appears to expect only the v1 format:

https://golang.org/src/go/internal/gccgoimporter/parser.go?h=parsePackageInit#L695

while the gccgo frontend has logic to specifically handle the v1 format:

https://github.com/golang/gofrontend/blob/master/go/import.cc#L466

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 13, 2016

CC @thanm

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 13, 2016

CL https://golang.org/cl/34371 mentions this issue.

@griesemer griesemer added this to the Go1.8 milestone Dec 13, 2016
@griesemer griesemer self-assigned this Dec 13, 2016
@golang golang locked and limited conversation to collaborators Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants