Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: weblist filtering not working #18385

Closed
benbjohnson opened this issue Dec 20, 2016 · 9 comments
Closed

cmd/pprof: weblist filtering not working #18385

benbjohnson opened this issue Dec 20, 2016 · 9 comments

Comments

@benbjohnson
Copy link

@benbjohnson benbjohnson commented Dec 20, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

Go 1.8 beta2

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/benbjohnson/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/49/56mhx0pn5vl_h2hzd90v9d1c0000gn/T/go-build341403676=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?

# In terminal #1
$ go install github.com/influxdata/influxdb/cmd/influxd
$ influxd
# In terminal #2
$ go tool pprof ~/go/bin/influxd http://localhost:8086/debug/pprof/heap
(pprof) weblist .

What did you expect to see?

A listing of functions in my web browser.

What did you see instead?

The weblist command returns "no samples found on routines matching: ." in 1.8beta2.

It works properly in Go 1.7. The list command in 1.8beta2 also works correctly.

@dsnet dsnet added this to the Go1.8 milestone Dec 20, 2016
@dsnet
Copy link
Member

@dsnet dsnet commented Dec 20, 2016

@ianlancetaylor ianlancetaylor changed the title runtime/pprof: weblist filtering not working cmd/pprof: weblist filtering not working Dec 20, 2016
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 20, 2016

When testing with a simple program the weblist command seems to work.

Will take a look at the influxdata code.

@benbjohnson
Copy link
Author

@benbjohnson benbjohnson commented Dec 20, 2016

@ianlancetaylor It doesn't seem to be specific to influxdb. I just tried it on some other packages with the same result. Perhaps it's just a fluke on my system.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 21, 2016

@benbjohnson Can you test with https://play.golang.org/p/eOlUFUFGAR ? That one worked for me.

@ALTree
Copy link
Member

@ALTree ALTree commented Dec 21, 2016

I've seen this on current tip while working on the tree.

Let
go = version go1.7.3
gotip = devel +0ef4815150 Wed Dec 21

Now:

$ cd src/strconv
$ gotip test -c
$ ./strconv.test -test.bench=FormatFloat/Slowpath64 -test.cpuprofile=cpu.prof

using tip pprof:

$ gotip tool pprof ./strconv.test cpu.prof 
Entering interactive mode (type "help" for commands)
(pprof) weblist
no samples found on routines matching: .

but go 1.7 pprof works:

$ go tool pprof ./strconv.test cpu.prof 
Entering interactive mode (type "help" for commands)
(pprof) weblist
[actually opens the webprofile]
@ALTree
Copy link
Member

@ALTree ALTree commented Dec 21, 2016

disasm is also broken. For example, disasm rightShift (on the strconv.test binary above) disassembles the function in 1.7, but prints nothing on tip.

@ALTree
Copy link
Member

@ALTree ALTree commented Dec 21, 2016

Looks like it has been broken by CL 23781 (cmd/pprof: instruction-level granularity in callgrind output).

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 21, 2016

@dsnet dsnet added NeedsFix and removed NeedsInvestigation labels Dec 21, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 21, 2016

CL https://golang.org/cl/34665 mentions this issue.

@gopherbot gopherbot closed this in 8887be4 Dec 22, 2016
@golang golang locked and limited conversation to collaborators Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.