Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: document predefined profiles under Profiles #18505

Closed
rakyll opened this issue Jan 3, 2017 · 2 comments
Closed

runtime/pprof: document predefined profiles under Profiles #18505

rakyll opened this issue Jan 3, 2017 · 2 comments
Labels
Documentation FrozenDueToAge
Milestone
Go1.9

Comments

@rakyll
Copy link
Contributor

rakyll commented Jan 3, 2017

It is backwards for pprof.Profile to document the predefined profiles rather than pprof.Profiles or pprof.Lookup. Given the documentation of the predefined is required by multiple APIs under the pprof package, we might consider documenting them under the package doc.
@rakyll rakyll added this to the Go1.9 milestone Jan 3, 2017
@rakyll rakyll changed the title runtime/pprof: document predefined profiles under package godoc runtime/pprof: document predefined profiles under Profiles Feb 6, 2017
@gopherbot
Copy link

CL https://golang.org/cl/36326 mentions this issue.

@bradfitz
Copy link
Contributor

bradfitz commented Jul 6, 2017

The proposed CL was abandoned, so closing this.

@bradfitz bradfitz closed this as completed Jul 6, 2017
@golang golang locked and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@bradfitz @rakyll @gopherbot