Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: add a "close" button for the "About" screen #18546

Open
broady opened this issue Jan 6, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@broady
Copy link
Member

commented Jan 6, 2017

At the moment, the screen closes when it's clicked anywhere.

Add a proper modal dialog with a close button.

/cc @rsc @bradfitz

@broady broady added this to the Unreleased milestone Jan 6, 2017

@broady broady self-assigned this Jan 6, 2017

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2017

Yes please. :-)

@gopherbot

This comment has been minimized.

Copy link

commented Oct 25, 2017

Change https://golang.org/cl/73570 mentions this issue: playground: add a close button for the about screen

@ysmolsky

This comment has been minimized.

Copy link
Member

commented Mar 3, 2018

Trying my hand on it. Something like this? Don't pay attention to font/styles/colors yet.

screen shot 2018-03-03 at 17 14 30

Clicking outside of modal dialog gets it closed. Clicking in the dialog does not close it, except for X button.

ping @andybons

Thoughts?

@andybons

This comment has been minimized.

Copy link
Member

commented Mar 7, 2018

Yes that’s fine with me. We can work on styling when the review is sent.

@andybons andybons added the NeedsFix label Mar 7, 2018

@ysmolsky ysmolsky changed the title playground: add a "close" button for the "About" screen x/playground: add a "close" button for the "About" screen May 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.