Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: auto submit bot? #18552

Closed
minux opened this issue Jan 6, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@minux
Copy link
Member

commented Jan 6, 2017

Relevant discussion: https://groups.google.com/d/msg/golang-dev/afkXKoAd8IQ/S8G8_YfaEAAJ

Right now it is impossible to see if a CL author can submit or not from Gerrit CL page.
Either make Gerrit show such or just make trybot also in charge of submission?

Brad said in the mailing list thread:

We could have a bot that auto-rebases and auto-tests +2ed CLs, and if they're not merged in N hours, it could add a reviewer who has +2 access, leaving a comment at the same time like, "This CL is rebased & tests pass. It needs somebody to press submit."

(unless the CL had some sort of AUTOSUBMIT=true comment, in which case it'd just happen)

Related #9858 (trybot should rebase when testing)
/cc @bradfitz

@minux minux added this to the Unreleased milestone Jan 6, 2017

@mvdan

This comment has been minimized.

Copy link
Member

commented Jan 7, 2017

Kubernetes has had something like this for years. @thockin any wisdom to share? Don't know who actually engineered @k8s-merge-robot, though.

@thockin

This comment has been minimized.

Copy link

commented Jan 7, 2017

@mvdan

This comment has been minimized.

Copy link
Member

commented Jan 7, 2017

Thanks @thockin. I wanted to bring up the bot because I don't think Go itself re-runs tests after every cherry-pick. For example: https://go-review.googlesource.com/#/c/29137/

The two CLs mentioned were green separately. The bot could have picked it up.

@gopherbot gopherbot added the Builders label Mar 21, 2017

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 12, 2017

Minux, you already filed this bug and your dup is still open: #12482

@bradfitz bradfitz closed this May 12, 2017

@golang golang locked and limited conversation to collaborators May 12, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.