New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestServerHijackGetsBackgroundByte failing on Plan 9 #18657

Open
0intro opened this Issue Jan 14, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@0intro
Member

0intro commented Jan 14, 2017

CL 5232 added TestServerHijackGetsBackgroundByte, which is failing on Plan 9; because CloseWrite is not implemented on Plan 9.

--- FAIL: TestServerHijackGetsBackgroundByte (0.08s)
	serve_test.go:5235: close tcp 127.0.0.1:43532->127.0.0.1:34277: not supported by plan 9
FAIL

See https://build.golang.org/log/2024e8d36966ea930ef6b6acd2c744e24734c2aa

This related to issue #17906.

@0intro 0intro added the OS-Plan9 label Jan 14, 2017

@0intro 0intro added this to the Go1.9Early milestone Jan 14, 2017

@0intro 0intro self-assigned this Jan 14, 2017

@gopherbot

This comment has been minimized.

gopherbot commented Jan 14, 2017

CL https://golang.org/cl/35178 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 14, 2017

net/http: skip TestServerHijackGetsBackgroundByte on Plan 9
CL 5232 added TestServerHijackGetsBackgroundByte, which is failing
on Plan 9, because CloseWrite is not implemented on Plan 9 yet.

Updates #17906.
Updates #18657.

Change-Id: I3c2f73760b0f767f3f9ed2698c855372170e0481
Reviewed-on: https://go-review.googlesource.com/35178
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@bradfitz bradfitz modified the milestones: Go1.9Early, Unplanned May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment