/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestServerHijackGetsBackgroundByte_big failing on Plan 9 #18658

Open
0intro opened this Issue Jan 14, 2017 · 1 comment

Comments

Assignees

@0intro 0intro

Labels
Projects
None yet
Milestone
  Unplanned
3 participants
@0intro @gopherbot @bradfitz
@0intro
Member

0intro commented Jan 14, 2017

CL 35234 added TestServerHijackGetsBackgroundByte_big, which is failing on Plan 9, because CloseWrite is not implemented on Plan 9.

--- FAIL: TestServerHijackGetsBackgroundByte_big (0.05s)
	serve_test.go:5300: close tcp 127.0.0.1:63062->127.0.0.1:36638: not supported by plan 9
FAIL

See https://build.golang.org/log/8e4622c7d73d3c7c243bcd84d2e366616fc8ce36

This related to issue #17906.

@0intro 0intro added the OS-Plan9 label Jan 14, 2017

@0intro 0intro added this to the Go1.9Early milestone Jan 14, 2017

@0intro 0intro self-assigned this Jan 14, 2017

@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Jan 14, 2017

CL https://golang.org/cl/35179 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 14, 2017

@0intro @bradfitz
net/http: skip TestServerHijackGetsBackgroundByte_big on Plan 9 
CL 35234 added TestServerHijackGetsBackgroundByte_big, which is failing
on Plan 9, because CloseWrite is not implemented on Plan 9 yet.

Updates #17906.
Updates #18658.

Change-Id: Icaf3fe3600d586515ecd92aca874104ea81ce6b9
Reviewed-on: https://go-review.googlesource.com/35179
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
e395e32

@bradfitz bradfitz modified the milestones: Go1.9Early, Unplanned May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment