Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/present: typo in error message #18670

Closed
rhcarvalho opened this issue Jan 15, 2017 · 1 comment
Closed

x/tools/present: typo in error message #18670

rhcarvalho opened this issue Jan 15, 2017 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@rhcarvalho
Copy link
Contributor

What version of Go are you using (go version)?

go version go1.7.3 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/rodolfo/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build050805424=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?

  1. Create a file example.slide:
Example

* example

.iframe 1 2 3 4

  1. Run present

  2. Browse to http://127.0.0.1:3999/example.slide

What did you expect to see?

incorrect iframe invocation: ".iframe 1 2 3 4"

What did you see instead?

incorrect image invocation: ".iframe 1 2 3 4"

The typo is in https://github.com/golang/tools/blob/0d047c8d5a8c3a1c89d9d78511f4ed7aef49ea0c/present/iframe.go#L42.
@ALTree ALTree added NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do. labels Jan 15, 2017
@ALTree ALTree added this to the Unreleased milestone Jan 15, 2017
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/35258 mentions this issue.

@golang golang locked and limited conversation to collaborators Jan 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@rhcarvalho @ALTree @gopherbot