Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "go test" accepts -test.FLAG where FLAG is any flag accepted by "go build" #18682

Open
minux opened this issue Jan 17, 2017 · 3 comments
Open
Assignees
Labels
Milestone

Comments

@minux
Copy link
Member

@minux minux commented Jan 17, 2017

This behavior always existed from Go 1.0.

For example:

$ go test image -test.work
WORK=/tmp/go-build271188011
ok  	image	0.361s

Is this expected? I find it quite confusing as there is no -test.work flag documented anywhere and it conflicts with user defined -test.FLAG flags. If this is WAI, we probably should document it.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Jun 22, 2017

Yes, we should definitely fix this, but I think it's too late for Go 1.9.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Apr 18, 2018

/cc @bcmills

@bcmills bcmills added the NeedsFix label Jan 18, 2019
@bcmills bcmills self-assigned this Jan 22, 2020
@bcmills bcmills modified the milestones: Unplanned, Go1.15 Jan 22, 2020
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Jan 22, 2020

I think CL 211358 will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.