Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: use proxy from environment #18736

Closed
walken-google opened this issue Jan 21, 2017 · 4 comments
Closed

cmd/pprof: use proxy from environment #18736

walken-google opened this issue Jan 21, 2017 · 4 comments
Assignees

Comments

@walken-google
Copy link
Contributor

@walken-google walken-google commented Jan 21, 2017

Is there any reason for cmd/pprof not to use the proxy environment variables when defined ?

(actually, I would like it if the zero valued transport used the proxy defined by environment variables when available, but I think it's too late to change that at this point).

My use case is that I would like to pprof some devices through a socks5 proxy.

@walken-google walken-google self-assigned this Jan 21, 2017
@walken-google
Copy link
Contributor Author

@walken-google walken-google commented Jan 21, 2017

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 24, 2017

CL https://golang.org/cl/35489 mentions this issue.

@walken-google
Copy link
Contributor Author

@walken-google walken-google commented Mar 2, 2017

Fixed in upstream pprof repo (which is now vendored into the main go repo)

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 19, 2017

CL https://golang.org/cl/38343 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 19, 2017
See #18736

Change-Id: I9c16357c05c16db677125d3077ee466b71559c7a
Reviewed-on: https://go-review.googlesource.com/38343
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.