Skip to content

cmd/pprof: remove redundant URLs in error messages #18754

@vcabbage

Description

@vcabbage

What version of Go are you using (go version)?

go version go1.8rc2 darwin/amd64

What did you do?

As observed in #18746:

# go tool pprof ./project http://localhost:5000/debug/pprof/profile
Fetching profile from http://localhost:5000/debug/pprof/profile
Please wait... (30s)
http fetch http://localhost:5000/debug/pprof/profile: Get http://localhost:5000/debug/pprof/profile: EOF

The URLs in the message are redundant, making the relevant portion less obvious. I propose omitting the redundant URL when the error is of type *url.Error.

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions