Skip to content

cmd/pprof: remove redundant URLs in error messages #18754

Closed
Closed
cmd/pprof: remove redundant URLs in error messages#18754
Labels
FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.
Milestone
Go1.9

Description

@vcabbage
vcabbage
opened on Jan 22, 2017

What version of Go are you using (go version)?

go version go1.8rc2 darwin/amd64

What did you do?

As observed in #18746:

# go tool pprof ./project http://localhost:5000/debug/pprof/profile
Fetching profile from http://localhost:5000/debug/pprof/profile
Please wait... (30s)
http fetch http://localhost:5000/debug/pprof/profile: Get http://localhost:5000/debug/pprof/profile: EOF

The URLs in the message are redundant, making the relevant portion less obvious. I propose omitting the redundant URL when the error is of type *url.Error.

Activity

  1. bradfitz commented on Jan 22, 2017

    @bradfitz
    bradfitz
    on Jan 22, 2017
    Contributor

    It's always of type *url.Error if it comes from an http.Client.

  2. bradfitz
    added this to the Go1.9 milestone on Jan 22, 2017
  3. bradfitz
    added
    NeedsFixThe path to resolution is known, but the work has not been done.
    on Jan 22, 2017

  4. gopherbot commented on Jan 24, 2017

    @gopherbot
    gopherbot
    on Jan 24, 2017
    Contributor

    CL https://golang.org/cl/35650 mentions this issue.

  5. gopherbot
    closed this as completedin 5b1c6efon Feb 1, 2017
  6. golang
    locked and limited conversation to collaborators on Feb 1, 2018
  7. gopherbot
    added
    FrozenDueToAge
    on Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions