Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: remove redundant URLs in error messages #18754

Closed
vcabbage opened this issue Jan 22, 2017 · 2 comments
Closed

cmd/pprof: remove redundant URLs in error messages #18754

vcabbage opened this issue Jan 22, 2017 · 2 comments

Comments

@vcabbage
Copy link
Member

@vcabbage vcabbage commented Jan 22, 2017

What version of Go are you using (go version)?

go version go1.8rc2 darwin/amd64

What did you do?

As observed in #18746:

# go tool pprof ./project http://localhost:5000/debug/pprof/profile
Fetching profile from http://localhost:5000/debug/pprof/profile
Please wait... (30s)
http fetch http://localhost:5000/debug/pprof/profile: Get http://localhost:5000/debug/pprof/profile: EOF

The URLs in the message are redundant, making the relevant portion less obvious. I propose omitting the redundant URL when the error is of type *url.Error.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jan 22, 2017

It's always of type *url.Error if it comes from an http.Client.

@bradfitz bradfitz added this to the Go1.9 milestone Jan 22, 2017
@bradfitz bradfitz added the NeedsFix label Jan 22, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 24, 2017

CL https://golang.org/cl/35650 mentions this issue.

@gopherbot gopherbot closed this in 5b1c6ef Feb 1, 2017
@golang golang locked and limited conversation to collaborators Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.