Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: need to establish a common wait time to return conns to pool #18759

Closed
kardianos opened this issue Jan 23, 2017 · 1 comment
Closed
Assignees

Comments

@kardianos
Copy link
Contributor

@kardianos kardianos commented Jan 23, 2017

From
https://build.golang.org/log/73f2669c736381aa9b2e345f9a582972a493929d
https://build.golang.org/log/5a47d23e13e67143640eeed8f231506a6bae927e

both mips hosts.

https://build.golang.org/log/ffb549b79f60b89283776a265cad961797cd39a1

from arm.

--- FAIL: TestQueryContext (0.01s)
	sql_test.go:330: free conns after query hitting EOF = 0; want 1
	sql_test.go:156: 1 connections still open after closing DB
FAIL
FAIL	database/sql	0.901s

I don't think this is a critical issue in the sql code itself. I think this is an issue in how the test is implemented. The check for number of conns in the DB pool has often been an issue when constructing the test. Due to how the conn pool is constructed (uses non-blocking channels internally) it is not deterministic in the behavior.

This may not be go1.8 worthy.

@kardianos kardianos self-assigned this Jan 23, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 25, 2017

CL https://golang.org/cl/35750 mentions this issue.

@gopherbot gopherbot closed this in 165cfbc Jan 25, 2017
@golang golang locked and limited conversation to collaborators Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.