Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upx/net/http2: WriteDataPadded shouldn't accepted padding characters #18809
Comments
daurnimator
changed the title
This comment has been minimized.
This comment has been minimized.
|
Note the API permits writing invalid stuff: https://godoc.org/golang.org/x/net/http2#Framer ... has both AllowIllegalWrites and AllowIllegalReads. This is useful for testing other implementations. But I agree that there's something to do here. We should probably validate the pad on write unless AllowIllegalWrites is set. |
odeke-em
changed the title
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/36118 mentions this issue. |
c3mb0
pushed a commit
to c3mb0/net
that referenced
this issue
Apr 2, 2018
…lWrites Fixes golang/go#18809 Change-Id: Ib1014f3ebe5a57dde30b4eaf287a2cbff3c1179c Reviewed-on: https://go-review.googlesource.com/36118 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Tom Bergan <tombergan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Carrying over from summerwind/h2spec#71 (comment)
In http2, padding MUST be null bytes. It makes no sense for
WriteDataPaddedto take padding bytes as an argument (it should only take the number of bytes)