Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: run cl2issue on GKE #18818

Closed
bradfitz opened this issue Jan 27, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@bradfitz
Copy link
Member

commented Jan 27, 2017

As part of #18817 ("Kubernetes-ify all misc build services & bots"), this is a tracking bug to also migrate @rsc's https://godoc.org/rsc.io/github/cl2issue bot:

@rsc writes:

The code is in rsc.io/github/cl2issue if anyone wants to make it part of the build infrastructure (please!).

/cc @kevinburke @rakyll @quentinmit

@bradfitz bradfitz added the Builders label Jan 27, 2017

@bradfitz bradfitz added this to the Unreleased milestone Jan 27, 2017

@mxplusb

This comment has been minimized.

Copy link

commented Apr 6, 2017

Is there a base container image to use?

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2017

The new plan is to put this functionality into golang.org/x/build/cmd/gopher

There's an outstanding CL (https://go-review.googlesource.com/c/39352/) that indexes the github references. Once that's in, this becomes a few lines in gopherbot.

@mxplusb

This comment has been minimized.

Copy link

commented Apr 11, 2017

Cool, should this be closed, then?

@rsc

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2017

It should be closed once the new bot is running.

@bradfitz bradfitz self-assigned this Apr 11, 2017

@kevinburke

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2017

I'm happy to take this one... Currently cl2issue calls exec.Command("issue", ...) which seems a little funky since issue is also a Go binary. It seems like we could just make a function call from within the same process and avoid needing to install a separate binary.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2017

Kevin, this will just be a few line gopherbot task like the others, once CL 39352 is in.

@gopherbot

This comment has been minimized.

Copy link

commented Apr 17, 2017

CL https://golang.org/cl/39352 mentions this issue.

@golang golang locked and limited conversation to collaborators Apr 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.