Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: document ConnectionState.NegotiatedProtocol more clearly #18841

Closed
nhooyr opened this issue Jan 29, 2017 · 1 comment
Closed

crypto/tls: document ConnectionState.NegotiatedProtocol more clearly #18841

nhooyr opened this issue Jan 29, 2017 · 1 comment
Labels
FrozenDueToAge

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Jan 29, 2017 •
edited

NegotiatedProtocol's documentation implies that it will always be
from Config.NextProtos but with NPN, a client can select a protocol that
the server does not support. Or with ALPN, a server can potentially select a
protocol that the client does not support (though that is reflected in Config.NextProtosIsMutual).
@gopherbot
Copy link

CL https://golang.org/cl/35917 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 1, 2018
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
@nhooyr @bradfitz
crypto/tls: document ConnectionState.NegotiatedProtocol more clearly
0c21fe3 
ConnectionState.NegotiatedProtocol's documentation implies that it will
always be from Config.NextProtos. This commit clarifies that there is no
guarantee.

This commit also adds a note to
ConnectionState.NegotiatedProtocolIsMutual, making it clear that it is
client side only.

Fixes golang#18841

Change-Id: Icd028af8042f31e45575f1080c5e9bd3012e03d7
Reviewed-on: https://go-review.googlesource.com/35917
Reviewed-by: Filippo Valsorda <hi@filippo.io>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
@nhooyr @bradfitz
crypto/tls: document ConnectionState.NegotiatedProtocol more clearly
c7f1c5b 
ConnectionState.NegotiatedProtocol's documentation implies that it will
always be from Config.NextProtos. This commit clarifies that there is no
guarantee.

This commit also adds a note to
ConnectionState.NegotiatedProtocolIsMutual, making it clear that it is
client side only.

Fixes golang#18841

Change-Id: Icd028af8042f31e45575f1080c5e9bd3012e03d7
Reviewed-on: https://go-review.googlesource.com/35917
Reviewed-by: Filippo Valsorda <hi@filippo.io>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @nhooyr