testing: -timeout affects benchmarks too (regression)

This regression was introduced in ead08e9#diff-70e628298261565d825f7199d13042f2L758

package bench

import (
        "testing"
        "time"
)

func BenchmarkSleep10(b *testing.B) {
        time.Sleep(10 * time.Second)
}

go test -v -bench=. -timeout=1s

go version go1.7.5 linux/amd64

BenchmarkSleep10-2             1        10000282918 ns/op
PASS

go version devel +6bdb0c1 Sun Jan 29 00:49:56 2017 +0000 linux/amd64

panic: test timed out after 1s

Looks like stopAlarm() was removed by rsc between patch set 4 and 5, but in the CL discussion I see nothing that can explain why.

I've cooked up a quick patch and in theory just adding back a stopAlarm() call after runExamples() should fix the problem, but I'm not confident I'm not missing something.

CL https://golang.org/cl/35956 mentions this issue.

CL https://golang.org/cl/36125 mentions this issue.

[release-branch.go1.8] testing: stop timeout-timer after running tests

Navigation Menu

Repository navigation

testing: -timeout affects benchmarks too (regression) #18845

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

testing: -timeout affects benchmarks too (regression) #18845

Description

Activity

ALTree commented on Jan 29, 2017

gopherbot commented on Jan 29, 2017

gopherbot commented on Feb 2, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions